OBPIH-7500 add createdby and updatedby fields to product supplier by ewaterman · Pull Request #5553 · openboxes/openboxes

ewaterman · 2025-10-14T21:56:28Z

✨ Description of Change

Link to GitHub issue or Jira ticket: https://pihemr.atlassian.net/browse/OBPIH-7500

Description: Add "createdBy" and "updatedBy" fields to product source/supplier and display them in the create/edit product source page.

📷 Screenshots & Recordings (optional)

ewaterman

Don't merge yet since I still need to confirm with Manon what the desired look is.

I also need to add the new localization labels once we agree on a look.

Also we likely want to filter out the fields when first creating the supplier. Or have it auto-populate with the name of the current user but idk how to do that on the frontend

ewaterman · 2025-10-14T21:57:23Z

src/css/colors.scss

  --gray-200: #D6D8DC;
  --gray-250: #D0DAED;
  --gray-300: #CED4DA;
-  --gray-350: #9299A6;


I noticed we have two --gray-350 so I removed one

ewaterman · 2025-10-14T21:58:51Z

src/js/components/form-elements/v2/style.scss


  &:disabled {
-    background-color: var(--blue-100);
+    background-color: var(--gray-200);


idk if it's just my monitor but I couldn't see blue-100 at all so it was very unclear when a field was disabled. We can revert this if we want but IMO it's much clearer this way:

Disabled field is the right one.

also, side note: DateField components don't dim the background when disabled so something must be going wrong there

The background probably doesn’t work because inside DatePicker we use customInput={<DateFieldInput onClear={onClear} clearable={clearable} />}, which has the .date-field-input className that overrides the .form-element-input className. If you also change it there to background-color: var(--gray-200), you should see the background

I personally don't mind the "grayer" version, so probably up to Manon

@ewaterman we wanted to merge that but we weren't sure whether you confirmed the color with Manon so I decided to ask her - she prefers not to get creative and change colors, so probably you need to change your monitor 🙈

RIP to my monitor 💀 (thanks for checking with Manon)

ewaterman · 2025-10-14T22:28:37Z

grails-app/domain/org/pih/warehouse/product/ProductSupplier.groovy

            dateCreated: dateCreated,
            lastUpdated: lastUpdated,
+            createdBy: createdBy?.name,
+            updatedBy: updatedBy?.name,


Another option for this would be:

updatedBy: updatedBy ? [ id: updatedBy?.id, name: updatedBy?.name, ] : null,

Alternatively, we can create a separate method for jsonifying the supplier for use in the product source list view. That one will have fewer fields (we don't fetch the associations because they're not used). Then this large toJson method can be used when fetching the supplier details.

I wanted to make as little changes as possible here so I just adding the single field, but we could to some minor optimizations here if we wanted. Idk if it's worth it though. Thoughts?

I would opt for adding the id, so to use this version:

updatedBy: updatedBy ? [ id: updatedBy?.id, name: updatedBy?.name, ] : null,

this would be easier to use if frontend ever needed to reference that

kchelstowski · 2025-10-15T09:54:32Z

grails-app/domain/org/pih/warehouse/product/ProductSupplier.groovy

            dateCreated: dateCreated,
            lastUpdated: lastUpdated,
+            createdBy: createdBy?.name,
+            updatedBy: updatedBy?.name,


I would opt for adding the id, so to use this version:

updatedBy: updatedBy ? [ id: updatedBy?.id, name: updatedBy?.name, ] : null,

this would be easier to use if frontend ever needed to reference that

kchelstowski · 2025-10-15T09:58:22Z

src/js/components/form-elements/v2/style.scss


  &:disabled {
-    background-color: var(--blue-100);
+    background-color: var(--gray-200);


I personally don't mind the "grayer" version, so probably up to Manon

kchelstowski · 2025-10-15T10:00:45Z

src/js/hooks/productSupplier/form/useProductSupplierForm.js

        active: productSupplier?.active,
        dateCreated: productSupplier?.dateCreated ?? undefined,
        lastUpdated: productSupplier?.lastUpdated ?? undefined,
+        createdBy: productSupplier?.createdBy ?? undefined,


I'm surprised if it's displayed correctly without having id, value, label properties

SebastianLib · 2025-10-15T19:07:02Z

src/js/components/productSupplier/create/subsections/BasicDetails.jsx

-              />
-            )}
+          <TextInput
+            name="basicDetails.created"


Is the name prop needed here? We usually use name inside <Controller> for controlled fields, but this one is just a display (disabled) field, so it’s probably not necessary

SebastianLib · 2025-10-15T19:07:20Z

src/js/components/productSupplier/create/subsections/BasicDetails.jsx

-              />
-            )}
+          <TextInput
+            name="basicDetails.updated"


codecov · 2025-10-16T16:20:04Z

Codecov Report

❌ Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 8.49%. Comparing base (1bb7314) to head (e3edd6d).
⚠️ Report is 145 commits behind head on develop.

Files with missing lines	Patch %	Lines
...n/org/pih/warehouse/product/ProductSupplier.groovy	22.22%	7 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             develop   #5553      +/-   ##
============================================
- Coverage       9.12%   8.49%   -0.64%     
+ Complexity      1170    1106      -64     
============================================
  Files            701     701              
  Lines          45281   45274       -7     
  Branches       10851   10850       -1     
============================================
- Hits            4131    3845     -286     
- Misses         40497   40857     +360     
+ Partials         653     572      -81

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

OBPIH-7500 add createdby and updatedby fields to product supplier

66facc6

ewaterman requested review from SebastianLib, alannadolny and kchelstowski October 14, 2025 21:56

ewaterman self-assigned this Oct 14, 2025

ewaterman added the status: work in progress For issues or pull requests that are in progress but not yet completed label Oct 14, 2025

make user name display correctly

8c429fb

ewaterman commented Oct 14, 2025

View reviewed changes

kchelstowski reviewed Oct 15, 2025

View reviewed changes

kchelstowski and others added 2 commits October 15, 2025 19:42

OBPIH-7500 Merge createdBy and dateCreated fields

8240a1f

clean up code, add l10n

b09ba56

github-actions bot added the domain: l10n Changes or discussions relating to localization & Internationalization label Oct 15, 2025

SebastianLib reviewed Oct 15, 2025

View reviewed changes

ewaterman added 2 commits October 15, 2025 12:33

return user id and name in json response

f1b8956

remove unused name prop

ce451b5

ewaterman removed the status: work in progress For issues or pull requests that are in progress but not yet completed label Oct 15, 2025

kchelstowski approved these changes Oct 16, 2025

View reviewed changes

revert color changes

e3edd6d

SebastianLib approved these changes Oct 16, 2025

View reviewed changes

ewaterman merged commit 6c17061 into develop Oct 16, 2025
7 checks passed

ewaterman deleted the ft/OBPIH-7500-product-supplier-audit-fields branch October 16, 2025 17:40

Uh oh!

Conversation

ewaterman commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Description of Change

📷 Screenshots & Recordings (optional)

Uh oh!

ewaterman left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SebastianLib Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SebastianLib Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ewaterman commented Oct 14, 2025 •

edited

Loading

ewaterman left a comment •

edited

Loading

SebastianLib Oct 14, 2025 •

edited

Loading

SebastianLib Oct 15, 2025 •

edited

Loading

codecov bot commented Oct 16, 2025 •

edited

Loading