OBPIH-7525 create 0 to 0 baseline transaction for products that were …#5545
Merged
awalkowiak merged 1 commit intodevelopfrom Oct 13, 2025
Merged
OBPIH-7525 create 0 to 0 baseline transaction for products that were …#5545awalkowiak merged 1 commit intodevelopfrom
awalkowiak merged 1 commit intodevelopfrom
Conversation
…zeroed mid cycle count
github-actions
bot
added
type: bug
kchelstowski
approved these changes
Oct 13, 2025
| // longer holds an association to that product (cycle count item holds the relationship to product). We still | ||
| // want to create a baseline for those products (to record that a count happened), hence the need to loop on | ||
| // the original list of counted products. | ||
| for (Product product : countedProducts) { |
Collaborator
There was a problem hiding this comment.
At what point don't cycleCount.products contain the "zeroed out" products? I'm asking because looking at the code and the changes, the countedProducts should be exactly the cycleCount.products.
I will leave the above if someone was also wondering.
I've answered myself - it's updateCycleCountItems method in the CycleCountProductAvailabilityService
awalkowiak
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…zeroed mid cycle count
✨ Description of Change
Link to GitHub issue or Jira ticket: https://pihemr.atlassian.net/browse/OBPIH-7525
Description: Creates a 0 quantity baseline transaction in the default bin and lot for products who had their quantity set to zero while in the middle of a cycle count.