OBPIH-7514 create 0 quantity baselines when migrating empty product i…#5526
Merged
awalkowiak merged 2 commits intorelease/0.9.5-hotfix3from Oct 2, 2025
Merged
Conversation
…nventory transactions
github-actions
bot
added
type: bug
ewaterman
commented
Oct 1, 2025
| // 5517. It is meant to be a temporary fix to OBPIH-7514 for the 0.9.5-hotfix3 release so that we can make | ||
| // as small of a change as possible for the hotfix (we don't want to impact the other features that create | ||
| // baselines). PR 5517 is targeted for 0.9.6 and so once 0.9.5-hotfix3 is completed, we should revert this. | ||
| Transaction createBaselineTransactionForMigration( |
Member
Author
There was a problem hiding this comment.
As the TODO says, this is just a copy paste of ProductInventoryTransactionService.createInventoryBaselineTransactionForGivenStock with the changes from #5517 applied.
Since this is meant to be a temp change that we eventually revert when copying back up to develop, I figured this was the simplest way to do it without affecting any other code.
alannadolny
approved these changes
Oct 2, 2025
awalkowiak
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nventory transactions
✨ Description of Change
Link to GitHub issue or Jira ticket: https://pihemr.atlassian.net/browse/OBPIH-7514
Description: A temp solution to https://pihemr.atlassian.net/browse/OBPIH-7230 for the hotfix release. This is mostly just a copy paste of #5517 but having it only apply to migrations, not the other features that create baselines. As the TODO says, we should revert this change when copying back up to develop.
📷 Screenshots & Recordings (optional)
Before:
After:
