OBPIH-7230 still create baseline transaction if QoH is zero#5517
Merged
OBPIH-7230 still create baseline transaction if QoH is zero#5517
Conversation
github-actions
bot
added
type: feature
ewaterman
requested review from
SebastianLib,
alannadolny,
awalkowiak and
kchelstowski
and removed request for
alannadolny
kchelstowski
approved these changes
Oct 3, 2025
alannadolny
approved these changes
Oct 3, 2025
awalkowiak
reviewed
Oct 3, 2025
Collaborator
awalkowiak
left a comment
awalkowiak
left a comment
There was a problem hiding this comment.
I think it looks good to me (there is one redundant method)
| return map.entrySet() | ||
| } | ||
|
|
||
| boolean isEmpty() { |
Member
Author
There was a problem hiding this comment.
I don't think so. I must have removed where I was using this.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #5517 +/- ##
=========================================
Coverage 9.12% 9.12%
Complexity 1170 1170
=========================================
Files 701 701
Lines 45281 45281
Branches 10851 10851
=========================================
Hits 4131 4131
Misses 40497 40497
Partials 653 653 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Just to be verbose, I reverted the change in #5526 as a part of this PR. That PR was designed to be a temporary fix that was meant only for release/0.9.5-hotfix3. This PR is the "proper" solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket: https://pihemr.atlassian.net/browse/OBPIH-7230
Description: We rely on the existance of transactions for last counted date, so even when we do a count on a product with no quantity and we count no quantity again, we still want that count action to be tracked and update last counted date.
This change will insert a baseline with quantity zero in the default lot and bin in the above scenario.
📷 Screenshots & Recordings (optional)
First I set the stock to zero with a record stock, then I did a second record stock, also setting stock to zero. You can see that we still create the second baseline in that scenario, even though there's no stock at the time
