OBPIH-7504 fixes to product inventory migration warnings#5502
OBPIH-7504 fixes to product inventory migration warnings#5502awalkowiak merged 2 commits intorelease/0.9.5-hotfix2from
Conversation
github-actions
bot
added
type: bug
| JOIN inventory_item ii1 ON te1.inventory_item_id = ii1.id | ||
| JOIN transaction t1 ON te1.transaction_id = t1.id | ||
| JOIN transaction_entry te2 ON te1.inventory_item_id != te2.inventory_item_id | ||
| JOIN transaction_entry te2 ON te1.transaction_id != te2.transaction_id |
There was a problem hiding this comment.
I think this is just a bug? We want to warn when there are two different transactions at the same time, not two different items.
There was a problem hiding this comment.
I think this is just a bug?
Yeah, I think it makes sense, because he previous version would skip two transactions made for the same inventory items
| OR | ||
| (t1.transaction_type_id != :transactionTypeId and t2.transaction_type_id = :transactionTypeId) | ||
| ) | ||
| AND (t1.transaction_type_id = :transactionTypeId OR t2.transaction_type_id = :transactionTypeId) |
There was a problem hiding this comment.
See this comment for context: https://pihemr.atlassian.net/browse/OBPIH-7504?focusedCommentId=167388.
From our investigation, we get issues when there are two product inventories at the same time that both cause adjustments since BOTH adjustments will be applied after we migrate.
I discussed with Manon and we thought the simplest solution was to just also warn about two product inventory transactions existing at the same time so that they can be fixed manually but let me know your thoughts @awalkowiak.
There was a problem hiding this comment.
@ewaterman Overall sounds good, but after this change, I think, all "single product" product inventory transactions will be displayed there as well, which are handled automatically, and these will be a noise on the migration page. So we'd need to just display these that are made from import (multiple products) and have common products
ewaterman
changed the title
2 participants
✨ Description of Change
Link to GitHub issue or Jira ticket: https://pihemr.atlassian.net/browse/OBPIH-7504
Description: See comments in the ticket. Two issues: