OBPIH-7160 Add filter for expired to stock transfer#5499
Merged
alannadolny merged 2 commits intodevelopfrom Sep 19, 2025
Merged
OBPIH-7160 Add filter for expired to stock transfer#5499alannadolny merged 2 commits intodevelopfrom
alannadolny merged 2 commits intodevelopfrom
Conversation
alannadolny
requested review from
SebastianLib,
awalkowiak,
ewaterman and
kchelstowski
github-actions
bot
added
type: feature
ewaterman
reviewed
Sep 16, 2025
| inventoryItem(JoinType.LEFT_OUTER_JOIN.joinTypeValue) { | ||
| lt('expirationDate', new Date()) | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Do we not want an inner join? If there is no inventory item, then we should hide the row, right? We only want to see expired, and so if there's no item, it can't be expired.
Member
There was a problem hiding this comment.
There should always be an inventory item (only bin location can be null, I think) so I think this makes sense.
ewaterman
approved these changes
Sep 17, 2025
Member
ewaterman
left a comment
ewaterman
left a comment
There was a problem hiding this comment.
I didn't review the frontend very thoroughly but approving the backend filtering
alannadolny
force-pushed
the
ft/OBPIH-7160
branch
from
0fb170b to
56f3686
Compare
jmiranda
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.