OBPIH-7475 bugfix null check when formatting date in GSPs#5489
Merged
OBPIH-7475 bugfix null check when formatting date in GSPs#5489
Conversation
github-actions
bot
added
type: bug
alannadolny
reviewed
Sep 9, 2025
Comment on lines
37
to
40
| if (attrs.date == null) { | ||
| out << '' | ||
| return | ||
| } |
Collaborator
There was a problem hiding this comment.
Why not move it into the switch case?
Member
Author
There was a problem hiding this comment.
I tried. You can't switch on null before Java 17 😞
EDIT: wait, maybe I'm wrong... Groovy might be able to handle it
alannadolny
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket: https://pihemr.atlassian.net/browse/OBPIH-7475
Description: N/A
📷 Screenshots & Recordings (optional)