As I said in the PR description, a more proper fix would be to change this query to distinguish between an empty list of products and a null list of products. However since we're so close to release I didn't want to break anything else in the system that uses this method so I opted to just put a TODO in for now and fixed it directly for inventory imports only.

I'm not sure if it handles all cases. As far as I'm concerned, we could have X items filled properly and leave only one item blank, and this would make every product to have quantities zeroed out.
If I read the code properly, you only handle a case when you have all items empty.

Can you say more about why you feel that way?

Any rows/items that are left blank are not included in inventoryImportData.products:

private InventoryImportData parseData(ImportDataCommand command) {
    InventoryImportData inventoryImportData = new InventoryImportData()
    for (def row in command.data) {
        // We've already warned the user during the validation step about any rows with a null QoH, so if there
        // are any that are still null at this point, simply ignore them.
        if (row.quantity == null) {
            continue
        }
    ...

If all rows are empty we get into the situation fixed by this ticket, but if only some of the items are empty and others set a quantity, then inventoryImportData.products will not be empty, and the if (products) condition in InventoryService.getTransactionEntriesBeforeDate will be true, and so it will fetch only the transaction entries for the given products.

List<TransactionEntry> getTransactionEntriesBeforeDate(Location facility, Collection<Product> products, Date date) {
    def criteria = TransactionEntry.createCriteria()
    return criteria.list {
        if (products) {
            inventoryItem {
                'in'("product", products)
            }
        }
        transaction {
            ...
        }
    } as List<TransactionEntry>
}

We use the result of this query to build ProductAvailability records (it does a call to inventoryService.getQuantityAsAvailableItems(transactionEntries)).

We then later only zero out any items whose products were in the import but didn't have a row for their specific item (can happen if a product is in multiple bins/lots and we only import one of those bins/lots):

// For all products in the import, any other bins/lots of those products that exist in the system (ie have
// a product availability entry) but were not in the import should have their quantity set to zero.
Set<String> keysInImport = inventoryImportData.rows.keySet()
for (entry in availableItems) {
    AvailableItem availableItem = entry.value

    if (keysInImport.contains(entry.key)) {
        continue
    }

    TransactionEntry transactionEntry = new TransactionEntry(
            transaction: transaction,
            quantity: -availableItem.quantityOnHand,
            product: availableItem.inventoryItem.product,
            binLocation: availableItem.binLocation,
            inventoryItem: availableItem.inventoryItem,
            comments: 'Item was not in inventory import file so quantity was assumed to be zero.',
    )
    transaction.addToTransactionEntries(transactionEntry)
}

Remember that in the above code, availableItems only contains data for the products that were imported, not ALL availableItems.

Maybe you're seeing something that I'm not, but I recorded a video demonstrating the behaviour: Screencast from 2025-08-06 08:29:14 AM.webm

Ok, I trust you. I just remember I ran into that edge case when I had a few lines filled properly and probably one line not filled.

hmm I tried again to reproduce it a few different ways with some lines filled out and others not but it always worked correctly after this fix. I'll merge the change in as is but we can keep an eye on it. Thanks for the review