OBPIH-7323 don't group by product when calculating inventory accuracy…#5398
Merged
awalkowiak merged 1 commit intodevelopfrom Jul 23, 2025
Merged
OBPIH-7323 don't group by product when calculating inventory accuracy…#5398awalkowiak merged 1 commit intodevelopfrom
awalkowiak merged 1 commit intodevelopfrom
Conversation
github-actions
bot
added
type: bug
alannadolny
approved these changes
Jul 22, 2025
jmiranda
approved these changes
Jul 23, 2025
Member
jmiranda
left a comment
jmiranda
left a comment
There was a problem hiding this comment.
The inventory_audit_rollup also sort of does this aggregation (at the transaction level). I think it's safer to use the cycle count data, but just wanted to mention that.
SebastianLib
approved these changes
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… indicator
✨ Description of Change
Link to GitHub issue or Jira ticket: https://pihemr.atlassian.net/browse/OBPIH-7323
Description: Change the inventory accuracy indicator to not group by products. That way if a product was counted multiple times within the given date interval, we treat them as separate counts. See "Additional description" section of ticket for details.
📷 Screenshots & Recordings (optional)