OBPIH-7370 button for skipping count assignment#5380
Conversation
github-actions
bot
added
type: feature
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5380 +/- ##
=========================================
Coverage 8.42% 8.42%
Complexity 1038 1038
=========================================
Files 666 666
Lines 44144 44144
Branches 10658 10658
=========================================
Hits 3718 3718
Misses 39857 39857
Partials 569 569 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| onClose()?.(); | ||
| redirectAfterClosingModal.current = CYCLE_COUNT.list(TO_RESOLVE_TAB); | ||
| openAssignCountModal(); | ||
| history.push(CYCLE_COUNT.list(TO_RESOLVE_TAB)); |
There was a problem hiding this comment.
Is the redirectAfterClosingModal necessary in other places after that change? I think it can be removed.
There was a problem hiding this comment.
it's still used to redirect to the resolve flow after you finish with the assignment when you click "resolve now". But you added this logic so maybe you're understanding something that I'm not
There was a problem hiding this comment.
usages of redirectAfterCloisingModal in that file:
// Page on which user should land after closing assign cycle count modal
const redirectAfterClosingModal = useRef(null);
history.push(redirectAfterClosingModal.current);
and
redirectAfterClosingModal.current = CYCLE_COUNT.resolveStep();
because the redirectAfterClosingModal can have only one value at this moment (redirect to the resolve step), so I think you can directly use:
history.push(CYCLE_COUNT.resolveStep());
2 participants
✨ Description of Change
Link to GitHub issue or Jira ticket: https://pihemr.atlassian.net/browse/OBPIH-7370
Description:
📷 Screenshots & Recordings (optional)