OBPIH-7287 Cycle count assignment fixes#5350
Merged
awalkowiak merged 11 commits intoft/OBPIH-7287-cycle-count-assignmentfrom Jun 27, 2025
Merged
OBPIH-7287 Cycle count assignment fixes#5350awalkowiak merged 11 commits intoft/OBPIH-7287-cycle-count-assignmentfrom
awalkowiak merged 11 commits intoft/OBPIH-7287-cycle-count-assignmentfrom
Conversation
github-actions
bot
added
domain: frontend
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ft/OBPIH-7287-cycle-count-assignment #5350 +/- ##
=========================================================================
- Coverage 8.41% 8.40% -0.01%
- Complexity 1016 1017 +1
=========================================================================
Files 664 664
Lines 44081 44112 +31
Branches 10656 10662 +6
=========================================================================
+ Hits 3708 3709 +1
- Misses 39805 39835 +30
Partials 568 568 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
awalkowiak
reviewed
Jun 27, 2025
|
|
||
| // Access to the information about available cycle count items before creating the cycle count | ||
| List<AvailableItem> getItemsAvailableForCycleCount() { | ||
| CycleCountProductAvailabilityService cycleCountProductAvailabilityService = Holders.grailsApplication.mainContext.getBean(CycleCountProductAvailabilityService) |
Collaborator
There was a problem hiding this comment.
I don't like the idea of loading service in the domain. Is there an option to do this inside the service instead?
Collaborator
Author
There was a problem hiding this comment.
I also don't like that, but nothing better comes to my mind.
Collaborator
There was a problem hiding this comment.
I would just calculate it and concatenate with toJson result, or perhaps ou could just add a transient with setter for this one 🤔
awalkowiak
approved these changes
Jun 27, 2025
awalkowiak
merged commit c8fc4f5
into
ft/OBPIH-7287-cycle-count-assignment
7 checks passed
awalkowiak
pushed a commit
that referenced
this pull request
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.