OBPIH-7291 Assign count modal fixes, fix unassigning person for count/recount#5340
Merged
alannadolny merged 5 commits intoft/OBPIH-7287-cycle-count-assignmentfrom Jun 17, 2025
Merged
Conversation
github-actions
bot
added
domain: frontend
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ft/OBPIH-7287-cycle-count-assignment #5340 +/- ##
=========================================================================
- Coverage 8.39% 8.39% -0.01%
Complexity 1016 1016
=========================================================================
Files 661 661
Lines 43996 44000 +4
Branches 10641 10642 +1
=========================================================================
Hits 3693 3693
- Misses 39735 39739 +4
Partials 568 568 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
awalkowiak
requested changes
Jun 17, 2025
Collaborator
awalkowiak
left a comment
awalkowiak
left a comment
There was a problem hiding this comment.
Overall looks good to me, I have just minor change request
| cycleCountRequest.countDeadline = command.countDeadline | ||
| cycleCountRequest.recountAssignee = command.recountAssignee | ||
| cycleCountRequest.recountDeadline = command.recountDeadline | ||
| CycleCountAssignmentCommand countAssignment = command.getAssignmentByCountIndex("0") |
Collaborator
There was a problem hiding this comment.
Could this "0" be moved to COUNT_INDEX const or something?
| cycleCountRequest.countAssignee = countAssignment.assignee | ||
| cycleCountRequest.countDeadline = countAssignment.deadline | ||
| } | ||
| CycleCountAssignmentCommand recountAssignment = command.getAssignmentByCountIndex("1") |
Collaborator
There was a problem hiding this comment.
Could this "0" be moved to FIRST_RECOUNT_INDEX or RECOUNT_INDEX const or something?
| countDeadline: dateWithoutTimeZone({ | ||
| date: deadline, | ||
| }), | ||
| 1: { |
Collaborator
There was a problem hiding this comment.
Can we move these keys to const too?
awalkowiak
reviewed
Jun 17, 2025
Collaborator
There was a problem hiding this comment.
@alannadolny Just one additional question - is there a way to clear the assignee? Looks like once it is set it cannot be cleared from cycle count request, only changed. Is that correct? NVM, I see it now
alannadolny
merged commit 0d151a3
into
ft/OBPIH-7287-cycle-count-assignment
7 checks passed
alannadolny
added a commit
that referenced
this pull request
Jun 18, 2025
awalkowiak
pushed a commit
that referenced
this pull request
Jun 25, 2025
awalkowiak
pushed a commit
that referenced
this pull request
Jun 26, 2025
alannadolny
added a commit
that referenced
this pull request
Jun 26, 2025
alannadolny
added a commit
that referenced
this pull request
Jun 26, 2025
awalkowiak
pushed a commit
that referenced
this pull request
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.