OBPIH-7290 Assign counted by and recounted by while creating CC#5336
Merged
awalkowiak merged 1 commit intoft/OBPIH-7287-cycle-count-assignmentfrom Jun 17, 2025
Merged
OBPIH-7290 Assign counted by and recounted by while creating CC#5336awalkowiak merged 1 commit intoft/OBPIH-7287-cycle-count-assignmentfrom
awalkowiak merged 1 commit intoft/OBPIH-7287-cycle-count-assignmentfrom
Conversation
alannadolny
requested review from
SebastianLib,
awalkowiak,
ewaterman and
kchelstowski
github-actions
bot
added
the
domain: backend
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ft/OBPIH-7287-cycle-count-assignment #5336 +/- ##
=========================================================================
- Coverage 8.38% 8.35% -0.04%
+ Complexity 1016 1002 -14
=========================================================================
Files 658 652 -6
Lines 43867 43808 -59
Branches 10618 10620 +2
=========================================================================
- Hits 3680 3658 -22
+ Misses 39619 39583 -36
+ Partials 568 567 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kchelstowski
approved these changes
Jun 16, 2025
| request.cycleCountRequest.status = CycleCountRequestStatus.IN_PROGRESS | ||
| Person assignee = request.cycleCountRequest.countAssignee | ||
| LocalDate countDeadline = request.cycleCountRequest.countDeadline | ||
| Date deadline = countDeadline ? DateUtil.asDate(countDeadline) : new Date() |
Collaborator
There was a problem hiding this comment.
I know it's not your convention, but it feels weird to me that we use two different names for the same thing. I'm just thinking why can't we call it dateCounted also on cycleCountRequest instead of deadline 🤔
awalkowiak
merged commit 4c7ec59
into
ft/OBPIH-7287-cycle-count-assignment
7 checks passed
alannadolny
added a commit
that referenced
this pull request
Jun 17, 2025
alannadolny
added a commit
that referenced
this pull request
Jun 18, 2025
awalkowiak
pushed a commit
that referenced
this pull request
Jun 25, 2025
awalkowiak
pushed a commit
that referenced
this pull request
Jun 26, 2025
alannadolny
added a commit
that referenced
this pull request
Jun 26, 2025
alannadolny
added a commit
that referenced
this pull request
Jun 26, 2025
awalkowiak
pushed a commit
that referenced
this pull request
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.