OBPIH-7292 Add “Assign count” buttons with the functionality#5326
Merged
awalkowiak merged 5 commits intoft/OBPIH-7287-cycle-count-assignmentfrom Jun 13, 2025
Merged
OBPIH-7292 Add “Assign count” buttons with the functionality#5326awalkowiak merged 5 commits intoft/OBPIH-7287-cycle-count-assignmentfrom
awalkowiak merged 5 commits intoft/OBPIH-7287-cycle-count-assignmentfrom
Conversation
alannadolny
requested review from
SebastianLib,
awalkowiak,
ewaterman and
kchelstowski
github-actions
bot
added
domain: frontend
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ft/OBPIH-7287-cycle-count-assignment #5326 +/- ##
=========================================================================
- Coverage 8.35% 8.32% -0.04%
+ Complexity 1002 999 -3
=========================================================================
Files 652 652
Lines 43796 43798 +2
Branches 10617 10618 +1
=========================================================================
- Hits 3658 3645 -13
- Misses 39571 39590 +19
+ Partials 567 563 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
awalkowiak
reviewed
Jun 13, 2025
Collaborator
awalkowiak
left a comment
awalkowiak
left a comment
There was a problem hiding this comment.
Overall I just dislike the existing AssignCycleCountModal. Is there still a PR pending with it? Could we improve it? Where? Does it require reopen of the modal related ticket? Rest lgtm
| <> | ||
| {isAssignCountModalOpen && ( | ||
| <AssignCycleCountModal | ||
| isOpen={isAssignCountModalOpen} |
Collaborator
There was a problem hiding this comment.
I am not sure if this is needed if you are rendering the modal only if isAssignCountModalOpen, so this could be true by default / not required?
| selectedCycleCountItems={assignCountModalData} | ||
| setSelectedCycleCountItems={setAssignCountModalData} | ||
| refetchData={fetchData} | ||
| isCount |
Collaborator
There was a problem hiding this comment.
If this is AssignCycleCountModal I think isCount should be a default version, and there should be isRecount instead.
| <AssignCycleCountModal | ||
| isOpen={isAssignCountModalOpen} | ||
| closeModal={closeAssignCountModal} | ||
| selectedCycleCountItems={assignCountModalData} |
Collaborator
There was a problem hiding this comment.
Does assignCountModalData contain items?
awalkowiak
merged commit 499cca3
into
ft/OBPIH-7287-cycle-count-assignment
7 checks passed
alannadolny
added a commit
that referenced
this pull request
Jun 17, 2025
alannadolny
added a commit
that referenced
this pull request
Jun 18, 2025
awalkowiak
pushed a commit
that referenced
this pull request
Jun 25, 2025
awalkowiak
pushed a commit
that referenced
this pull request
Jun 26, 2025
alannadolny
added a commit
that referenced
this pull request
Jun 26, 2025
alannadolny
added a commit
that referenced
this pull request
Jun 26, 2025
awalkowiak
pushed a commit
that referenced
this pull request
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.