OBPIH-7143 fail starting count when in pending outbound#5305
Merged
awalkowiak merged 1 commit intodevelopfrom Jun 4, 2025
Merged
OBPIH-7143 fail starting count when in pending outbound#5305awalkowiak merged 1 commit intodevelopfrom
awalkowiak merged 1 commit intodevelopfrom
Conversation
github-actions
bot
added
type: feature
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5305 +/- ##
============================================
+ Coverage 8.30% 8.34% +0.03%
- Complexity 994 1002 +8
============================================
Files 649 649
Lines 43650 43657 +7
Branches 10579 10583 +4
============================================
+ Hits 3625 3642 +17
+ Misses 39465 39453 -12
- Partials 560 562 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
awalkowiak
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket: https://pihemr.atlassian.net/browse/OBPIH-7143
Description: Kasia had a good point that when the product is in a pending outbound, we should also block users from starting a count (the other PR was for erroring when requesting a count). However we should only block the count from being started while it's in the "to count" state. Once there is progress in the count, it should be able to finish.
Initial PR: #5276