OBPIH-7337 export recount enhancements#5303
Conversation
github-actions
bot
added
type: feature
|
I was investigating this ticket this morning after poker planning and ended up essentially implementing it while I was figuring stuff out so I decided to finish it 🤷 |
|
|
||
| // Build a map to make it easier to group the count and recount items into one row in the XLS. | ||
| // The outer map is keyed on [product code + lot + bin]. The inner map is keyed on count index. | ||
| MultiKeyMap<String, Map<Integer, CycleCountItemDto>> countItemsMap = [:] |
There was a problem hiding this comment.
I quite like MultiKeyMap and MultiKey. I find them very useful as a way to avoid needing to make nested maps (though in this rare case I also have a nested map for convenience).
There was a problem hiding this comment.
nitpicky, but I think an interface should be the type, so in this case it should probably be:
IterableMap<String, Map<Integer, CycleCountItemDto>> countItemsMap = new MultiKeyMap()in the same way that we declare a list - we don't do:
ArrayList<String> = new ArrayList<>()but
List<String> = new ArrayList<>()
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5303 +/- ##
============================================
- Coverage 8.34% 8.29% -0.05%
+ Complexity 1002 994 -8
============================================
Files 649 649
Lines 43650 43684 +34
Branches 10579 10591 +12
============================================
- Hits 3642 3625 -17
- Misses 39446 39499 +53
+ Partials 562 560 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 participants
✨ Description of Change
Link to GitHub issue or Jira ticket: https://pihemr.atlassian.net/browse/OBPIH-7337
Description: Modified CycleCountService.getRecountFormXls to also export the value of “Quantity Recounted“, "Root Cause", “Comment“, “User Recounted“, and “Date Recounted“.
📷 Screenshots & Recordings (optional)