Skip to content

OBPIH-7195 fix2: error creating adjustment transaction if transaction already exists for given date#5294

Merged
awalkowiak merged 2 commits intodevelopfrom
bug/OBPIH-7195-2-adjustments-same-time
Jun 2, 2025
Merged

OBPIH-7195 fix2: error creating adjustment transaction if transaction already exists for given date#5294
awalkowiak merged 2 commits intodevelopfrom
bug/OBPIH-7195-2-adjustments-same-time

Conversation

@ewaterman
Copy link
Member

@ewaterman ewaterman commented May 30, 2025

✨ Description of Change

Link to GitHub issue or Jira ticket: https://pihemr.atlassian.net/browse/OBPIH-7195?

Description: Multiple fixes:

  1. fail an inventory import if a transaction already exists on the items with the same date as the adjustment transaction
  2. fix check that errors if transaction date is in the future
  3. add inventory import baseline transaction feature switch (I forgot to add it previously)
  4. fix record stock error due to autowiring in inventoryService twice

@ewaterman ewaterman self-assigned this May 30, 2025
@github-actions github-actions bot added type: bug Addresses unintended behaviours of the app domain: backend Changes or discussions relating to the backend server domain: l10n Changes or discussions relating to localization & Internationalization labels May 30, 2025
@codecov
Copy link

codecov bot commented May 30, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 11.11111% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 8.34%. Comparing base (cc85ea8) to head (7578959).
⚠️ Report is 109 commits behind head on develop.

Files with missing lines Patch % Lines
...rehouse/importer/InventoryImportDataService.groovy 0.00% 6 Missing ⚠️
...rg/pih/warehouse/importer/ImportDataCommand.groovy 0.00% 5 Missing ⚠️
...oryImportProductInventoryTransactionService.groovy 0.00% 2 Missing ⚠️
...nventory/ProductInventoryTransactionService.groovy 50.00% 1 Missing and 1 partial ⚠️
...ehouse/inventory/ProductAvailabilityService.groovy 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             develop   #5294      +/-   ##
============================================
- Coverage       8.35%   8.34%   -0.01%     
- Complexity      1000    1002       +2     
============================================
  Files            649     649              
  Lines          43611   43623      +12     
  Branches       10568   10570       +2     
============================================
  Hits            3642    3642              
- Misses         39408   39419      +11     
- Partials         561     562       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@awalkowiak awalkowiak merged commit a15b5a9 into develop Jun 2, 2025
8 checks passed
@awalkowiak awalkowiak deleted the bug/OBPIH-7195-2-adjustments-same-time branch June 2, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@awalkowiak awalkowiak awalkowiak approved these changes

@alannadolny alannadolny Awaiting requested review from alannadolny

Assignees

@ewaterman ewaterman

Labels

domain: backend Changes or discussions relating to the backend server domain: l10n Changes or discussions relating to localization & Internationalization type: bug Addresses unintended behaviours of the app

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ewaterman @awalkowiak