OBPIH-7195 fix: error creating baseline if a transaction already exists for given date#5287
Merged
awalkowiak merged 1 commit intodevelopfrom May 30, 2025
Conversation
github-actions
bot
added
type: maintenance
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5287 +/- ##
============================================
- Coverage 8.34% 8.31% -0.03%
+ Complexity 995 991 -4
============================================
Files 648 648
Lines 43511 43530 +19
Branches 10549 10550 +1
============================================
- Hits 3632 3621 -11
- Misses 39317 39350 +33
+ Partials 562 559 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alannadolny
approved these changes
May 29, 2025
awalkowiak
approved these changes
May 30, 2025
Collaborator
awalkowiak
left a comment
awalkowiak
left a comment
There was a problem hiding this comment.
Overall looks good, I am only wondering if it would be enough to just have a validation against Inventory Baseline transaction, not all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket: https://pihemr.atlassian.net/browse/OBPIH-7195
Description: Two fixes:
📷 Screenshots & Recordings (optional)