OBPIH-7241 Create table component for inventory transactions report (improvement)#5275
Merged
awalkowiak merged 6 commits intodevelopfrom May 27, 2025
Merged
OBPIH-7241 Create table component for inventory transactions report (improvement)#5275awalkowiak merged 6 commits intodevelopfrom
awalkowiak merged 6 commits intodevelopfrom
Conversation
github-actions
bot
added
the
domain: frontend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5275 +/- ##
============================================
+ Coverage 8.33% 8.35% +0.01%
- Complexity 977 993 +16
============================================
Files 645 646 +1
Lines 43368 43397 +29
Branches 10531 10535 +4
============================================
+ Hits 3613 3624 +11
- Misses 39204 39212 +8
- Partials 551 561 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alannadolny
reviewed
May 26, 2025
Comment on lines
271
to
280
| let percentageValue = 100; | ||
| if (quantityOnHand <= 0 && quantityCounted === 0) { | ||
| percentageValue = 0; | ||
| } | ||
| if (quantityOnHand > 0) { | ||
| percentageValue = Math.round((Math.abs(quantityVariance) / Math.abs(quantityOnHand)) * 100); | ||
| } | ||
| if (quantityOnHand <= 0 && quantityCounted !== 0) { | ||
| percentageValue = 100; | ||
| } |
Collaborator
There was a problem hiding this comment.
Please add a comments describing the behaviour here
awalkowiak
approved these changes
May 27, 2025
alannadolny
approved these changes
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket:
Description:
📷 Screenshots & Recordings (optional)