Merged
Conversation
We're not supporting MySQL 5.7 for 0.9.x releases any longer, and since we've started using CTEs (which are not supported in 5.7), this marks the final nail in the coffin for abandoning 5.7 support.
github-actions
bot
added
the
domain: devops
ewaterman
commented
May 22, 2025
| matrix: | ||
| # If we start actively supporting other databases, they should be added here so that we can test against them. | ||
| testdatabase: ["mysql:5.7.44", "mysql:8.0.36", "mariadb:10.3.39"] | ||
| testdatabase: ["mysql:8.0.36", "mariadb:10.3.39"] |
Member
Author
There was a problem hiding this comment.
I figured I'd make this a PR as a reminder for where this config lives. It's really easy to add/remove db versions to test against so if we upgrade in the future, all we need to do is remember to update this list
jmiranda
approved these changes
May 22, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5271 +/- ##
============================================
- Coverage 8.32% 8.29% -0.03%
+ Complexity 976 969 -7
============================================
Files 642 645 +3
Lines 43311 43368 +57
Branches 10523 10531 +8
============================================
- Hits 3604 3596 -8
- Misses 39156 39223 +67
+ Partials 551 549 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket: N/A
Description: We're not supporting MySQL 5.7 for 0.9.x releases any longer, and since we've started using CTEs (which are not supported in 5.7), this marks the final nail in the coffin for abandoning 5.7 support.