Skip to content

OBPIH-7203 change adjustment icon in stock history and remove migation buttons o…#5269

Merged
ewaterman merged 2 commits intodevelopfrom
maintenance/OBPIH-7203-adjustment-icon
May 23, 2025
Merged

OBPIH-7203 change adjustment icon in stock history and remove migation buttons o…#5269
ewaterman merged 2 commits intodevelopfrom
maintenance/OBPIH-7203-adjustment-icon

Conversation

@ewaterman
Copy link
Member

…n product page

✨ Description of Change

Link to GitHub issue or Jira ticket: https://pihemr.atlassian.net/browse/OBPIH-7203

Description:


📷 Screenshots & Recordings (optional)

Screenshot from 2025-05-21 13-34-50

@ewaterman ewaterman requested review from awalkowiak and jmiranda May 21, 2025 20:41
@ewaterman ewaterman self-assigned this May 21, 2025
@github-actions github-actions bot added type: maintenance Code improvements, optimizations and refactors, dependency upgrades... domain: frontend Changes or discussions relating to the frontend UI labels May 21, 2025
<g:else>
<img src="${resource(dir: 'images/icons/silk', file: 'arrow_down_red.png')}" title="${format.metadata(obj:stockHistoryEntry?.transaction?.transactionType)}"/>
</g:else>
<img src="${resource(dir: 'images/icons/silk', file: 'arrow_up_green_down_red.png')}" title="${format.metadata(obj:stockHistoryEntry?.transaction?.transactionType)}"/>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two ways to do this:

  1. Always show the up/down arrow for all adjustments, even if there are only credits or only debits, and only show it for the first entry of the adjustment transaction. This is how it's currently implemented.
    Screenshot from 2025-05-21 13-34-50

  2. Have adjustments show an icon for all entries of the transaction and have that icon either be an up or down arrow depending on if it's a positive/negative adjustment
    image

Both are easy to do, so we should decide which we prefer

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. I like the first one better.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the first one too. Is it just me, or the red arrow is a bit higher than the green one? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they're alligned 😄

image

@ewaterman ewaterman merged commit 4383ab9 into develop May 23, 2025
6 of 7 checks passed
@ewaterman ewaterman deleted the maintenance/OBPIH-7203-adjustment-icon branch May 23, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: frontend Changes or discussions relating to the frontend UI type: maintenance Code improvements, optimizations and refactors, dependency upgrades...

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants