Conversation
ewaterman
commented
May 21, 2025
| <g:else> | ||
| <img src="${resource(dir: 'images/icons/silk', file: 'arrow_down_red.png')}" title="${format.metadata(obj:stockHistoryEntry?.transaction?.transactionType)}"/> | ||
| </g:else> | ||
| <img src="${resource(dir: 'images/icons/silk', file: 'arrow_up_green_down_red.png')}" title="${format.metadata(obj:stockHistoryEntry?.transaction?.transactionType)}"/> |
Member
Author
There was a problem hiding this comment.
There are two ways to do this:
-
Always show the up/down arrow for all adjustments, even if there are only credits or only debits, and only show it for the first entry of the adjustment transaction. This is how it's currently implemented.

-
Have adjustments show an icon for all entries of the transaction and have that icon either be an up or down arrow depending on if it's a positive/negative adjustment

Both are easy to do, so we should decide which we prefer
Member
There was a problem hiding this comment.
Awesome. I like the first one better.
Collaborator
There was a problem hiding this comment.
I like the first one too. Is it just me, or the red arrow is a bit higher than the green one? 🤔
Member
Author
This was referenced Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

…n product page
✨ Description of Change
Link to GitHub issue or Jira ticket: https://pihemr.atlassian.net/browse/OBPIH-7203
Description:
📷 Screenshots & Recordings (optional)