OBPIH-7241 Create table component for inventory transactions report (improvements after QA)#5265
Merged
awalkowiak merged 3 commits intoOBPIH-7239from May 21, 2025
Merged
OBPIH-7241 Create table component for inventory transactions report (improvements after QA)#5265awalkowiak merged 3 commits intoOBPIH-7239from
awalkowiak merged 3 commits intoOBPIH-7239from
Conversation
…fix after QA) OBPIH-7241 Chsnge filterForm submit logic OBPIH-7241 Remove console.log OBPIH-7241 Add small corrections OBPIH-7241 Improve percentages logic OBPIH-7241 Changes in messages.properties OBPIH-7241 Simplify isSubmitDisabled logic OBPIH-7241 Add small correction OBPIH-7241 add isFilterRequired boolean OBPIH-7241 Remove isFilterRequired boolean
github-actions
bot
added
domain: frontend
alannadolny
reviewed
May 21, 2025
| > | ||
| <div className="limit-lines-1"> | ||
| {_.capitalize(getValue())} | ||
| {reasonCodes.find((c) => c.value === getValue())?.label} |
Collaborator
There was a problem hiding this comment.
I don't like that we are looping over reason codes to find the appropriate code to display (and I don't like the need for fetching). Can we add an enum on the front end and then get the label, calling something like ReasonCodes[getValue()]?
| defaultMessage: 'Select a time range from above filters to load the table.', | ||
| }; | ||
|
|
||
| const emptyTableMessage = !filterParams.startDate && !filterParams.endDate |
Collaborator
There was a problem hiding this comment.
Isn't the wrong error visible after changing the filters without fetching data?
Collaborator
Author
There was a problem hiding this comment.
no, because the filters are updated only when we click load table
awalkowiak
approved these changes
May 21, 2025
awalkowiak
pushed a commit
that referenced
this pull request
May 21, 2025
…improvements after QA) (#5265)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to GitHub issue or Jira ticket:
Description:
📷 Screenshots & Recordings (optional)