OBPIH-7003 Unify date format in filters and columns in CC tables#5264
Merged
awalkowiak merged 4 commits intoOBPIH-7239from May 21, 2025
Merged
OBPIH-7003 Unify date format in filters and columns in CC tables#5264awalkowiak merged 4 commits intoOBPIH-7239from
awalkowiak merged 4 commits intoOBPIH-7239from
Conversation
github-actions
bot
added
the
domain: frontend
awalkowiak
approved these changes
May 21, 2025
alannadolny
reviewed
May 21, 2025
Comment on lines
84
to
88
| dateLastCount: dateWithoutTimeZone({ | ||
| date: dateLastCount, | ||
| currentDateFormat: DateFormat.DD_MMM_YYYY, | ||
| outputDateFormat: DateFormat.MM_DD_YYYY, | ||
| }), |
Collaborator
There was a problem hiding this comment.
Because you are using that function with the same arguments in every place that you changed in that PR, you can create a function that already passes those arguments. I mean something like:
const formatCycleCountDate = (date) => dateWithoutTimeZone({
date: date,
currentDateFormat: DateFormat.DD_MMM_YYYY,
outputDateFormat: DateFormat.MM_DD_YYYY,
}),
I don't have better idea for the naming, so i believe that you can come up with something better
awalkowiak
approved these changes
May 21, 2025
awalkowiak
pushed a commit
that referenced
this pull request
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket:
Description:
📷 Screenshots & Recordings (optional)