OBPIH-7196 switch product merge to use baseline transaction type#5258
Merged
awalkowiak merged 1 commit intodevelopfrom May 16, 2025
Merged
Conversation
github-actions
bot
added
type: maintenance
ewaterman
commented
May 16, 2025
| Transaction transaction = new Transaction() | ||
| transaction.inventory = inventory | ||
| transaction.transactionType = TransactionType.get(Constants.PRODUCT_INVENTORY_TRANSACTION_TYPE_ID) | ||
| transaction.transactionType = TransactionType.get(Constants.INVENTORY_BASELINE_TRANSACTION_TYPE_ID) |
Member
Author
There was a problem hiding this comment.
it feels like it shouldn't be this simple 😅 I'm looking through to code to make sure I didn't miss something but let me know if you have any thoughts since I know you created the feature.
Collaborator
There was a problem hiding this comment.
Nope, that's it. But we included some time for QA to check this one.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5258 +/- ##
=========================================
Coverage 8.27% 8.27%
Complexity 965 965
=========================================
Files 641 641
Lines 43288 43288
Branches 10520 10520
=========================================
Hits 3583 3583
Misses 39155 39155
Partials 550 550 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
awalkowiak
deleted the
maintenance/OBPIH-7196-product-merge-transaction-type
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket: https://pihemr.atlassian.net/browse/OBPIH-7196
Description: Switch the product merge feature to use the new inventory baseline transaction type.