OBPIH-7246 Product and Transaction date filters for inventory transactions report#5249
Merged
awalkowiak merged 8 commits intoOBPIH-7241from May 13, 2025
Merged
OBPIH-7246 Product and Transaction date filters for inventory transactions report#5249awalkowiak merged 8 commits intoOBPIH-7241from
awalkowiak merged 8 commits intoOBPIH-7241from
Conversation
github-actions
bot
added
domain: frontend
alannadolny
reviewed
May 13, 2025
src/js/hooks/useTableDataV2.js
Outdated
| } | ||
| // Prevents automatic data fetching when resetInitialFetch is true, | ||
| // allowing fetch only on submit button click | ||
| if (resetInitialFetch && setResetInitialFetch) { |
Collaborator
There was a problem hiding this comment.
why do we check setResetInitialFetch? Isn't resetInitialFetch enough?
Collaborator
There was a problem hiding this comment.
If resetInitialFetch blocks from the initial fetch, then the naming isn't appropriate
alannadolny
approved these changes
May 13, 2025
Comment on lines
+51
to
+53
| if (setShouldFetch) { | ||
| setShouldFetch(true); | ||
| } |
Collaborator
There was a problem hiding this comment.
btw - you can use the following syntax: setShouldFetch?.(true)
awalkowiak
approved these changes
May 13, 2025
alannadolny
pushed a commit
that referenced
this pull request
May 13, 2025
alannadolny
pushed a commit
that referenced
this pull request
May 13, 2025
alannadolny
pushed a commit
that referenced
this pull request
May 14, 2025
alannadolny
pushed a commit
that referenced
this pull request
May 19, 2025
alannadolny
pushed a commit
that referenced
this pull request
May 21, 2025
awalkowiak
pushed a commit
that referenced
this pull request
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket:
Description:
📷 Screenshots & Recordings (optional)