OBPIH-7093 Small search and pagination issue on cc lists#5247
Merged
awalkowiak merged 4 commits intodevelopfrom May 16, 2025
Merged
OBPIH-7093 Small search and pagination issue on cc lists#5247awalkowiak merged 4 commits intodevelopfrom
awalkowiak merged 4 commits intodevelopfrom
Conversation
github-actions
bot
added
the
domain: frontend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5247 +/- ##
============================================
- Coverage 8.31% 8.31% -0.01%
Complexity 988 988
============================================
Files 638 638
Lines 43246 43251 +5
Branches 10511 10515 +4
============================================
Hits 3597 3597
- Misses 39096 39101 +5
Partials 553 553 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alannadolny
reviewed
May 9, 2025
src/js/hooks/useTablePagination.js
Outdated
Comment on lines
12
to
15
| // triggerFetchDataCounter triggers data fetching in useTableDataV2, preventing duplicate | ||
| // API calls. Previously, useEffect dependencies [filterParams, offset] caused two requests, | ||
| // as useTablePagination useEffect listened to filterParams and later updated offset | ||
| const [triggerFetchDataCounter, setTriggerFetchDataCounter] = useState(0); |
Collaborator
There was a problem hiding this comment.
I don't like any ideas that are related to endless counting. Maybe you can do something like concatenating the filterParams to get the trivial value (I mean string) and then pass it as a dependency to useEffect?
alannadolny
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket:
Description:
📷 Screenshots & Recordings (optional)