OBPIH-7193: add product inventory snapshot transaction type#5238
OBPIH-7193: add product inventory snapshot transaction type#5238awalkowiak merged 2 commits intodevelopfrom
Conversation
github-actions
bot
added
type: feature
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5238 +/- ##
============================================
- Coverage 8.31% 8.27% -0.04%
- Complexity 971 982 +11
============================================
Files 638 641 +3
Lines 43246 43288 +42
Branches 10511 10520 +9
============================================
- Hits 3596 3584 -12
- Misses 39097 39154 +57
+ Partials 553 550 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| <insert tableName="transaction_type"> | ||
| <column name="id" value="12" /> | ||
| <column name="version" value="0" /> | ||
| <column name="name" value="Product Inventory Snapshot" /> |
There was a problem hiding this comment.
@awalkowiak I realized later that you wanted the name to be "Product Snapshot", so I can change it if you prefer
There was a problem hiding this comment.
@ewaterman, actually, I wanted "Inventory Snapshot". However looks like there is still a debate between @jmiranda and Kelsey on how it should be named (see this comment https://pihemr.atlassian.net/browse/OBPIH-7193?focusedCommentId=163366), so let's confirm today which is the way to go.
| <insert tableName="transaction_type"> | ||
| <column name="id" value="12" /> | ||
| <column name="version" value="0" /> | ||
| <column name="name" value="Product Inventory Snapshot" /> |
There was a problem hiding this comment.
@ewaterman, actually, I wanted "Inventory Snapshot". However looks like there is still a debate between @jmiranda and Kelsey on how it should be named (see this comment https://pihemr.atlassian.net/browse/OBPIH-7193?focusedCommentId=163366), so let's confirm today which is the way to go.
2 participants
✨ Description of Change
Link to GitHub issue or Jira ticket: https://pihemr.atlassian.net/browse/OBPIH-7193
Description: Add the new "Product Inventory Snapshot" transaction type and switch cycle count to use it.
📷 Screenshots & Recordings (optional)
Cycle counts can successfully create the new "product inventory snapshot" transactions after the count is submitted:
And last counted date is still updated correctly: