OBPIH-7255: add support for ZonedDateTime to backend#5237
Merged
Conversation
github-actions
bot
added
the
type: feature
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #5237 +/- ##
============================================
- Coverage 8.31% 8.29% -0.02%
- Complexity 971 982 +11
============================================
Files 638 641 +3
Lines 43246 43317 +71
Branches 10511 10525 +14
============================================
- Hits 3596 3594 -2
- Misses 39097 39163 +66
- Partials 553 560 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-actions
bot
added
the
domain: backend
ewaterman
commented
May 14, 2025
| // default and replace it with "withZone" when parsing (see DateUtil.asDate). | ||
| // https://stackoverflow.com/questions/41999421/how-does-datetimeformatters-override-zone-work-when-parsing | ||
| // Defaults to the current timezone offset of the system if timezone is not provided in the String. | ||
| .parseDefaulting(ChronoField.OFFSET_SECONDS, DateUtil.getSystemZoneOffset().getTotalSeconds()) |
Member
Author
There was a problem hiding this comment.
This line is the only change in the whole PR that actually has any impact on existing code. Everything else isn't being used anywhere yet (except for tests).
This change doesn't have any impact on PIH servers since our tz is UTC, but it allows other servers (such as dominica) which are set up with a non-UTC timezone to be able to handle the case where timezone isn't provided by the frontend.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket: https://pihemr.atlassian.net/browse/OBPIH-7255
Description: