OBPIH-7242 Create "box" component for alignment and transaction type columns#5235
Merged
awalkowiak merged 2 commits intodevelopfrom May 5, 2025
Merged
OBPIH-7242 Create "box" component for alignment and transaction type columns#5235awalkowiak merged 2 commits intodevelopfrom
awalkowiak merged 2 commits intodevelopfrom
Conversation
github-actions
bot
added
domain: frontend
SebastianLib
commented
Apr 25, 2025
Comment on lines
-9
to
12
|
|
||
| const ArrowValueIndicator = ({ value, variant, showAbsoluteValue }) => { | ||
| const ValueIndicator = ({ | ||
| value, variant, showAbsoluteValue, transactionType, | ||
| }) => { | ||
| const translate = useTranslate(); |
Collaborator
Author
There was a problem hiding this comment.
@alannadolny what do you think about my idea to rename ArrowValueIndicatorVariant to valueIndicatorVariant and extend this function to also use it in the inventory changes report?
alannadolny
approved these changes
May 5, 2025
Comment on lines
2
to
8
| EQUAL: 'EQUAL', | ||
| EMPTY: 'EMPTY', | ||
| POSITIVE: 'POSITIVE', | ||
| NEGATIVE: 'NEGATIVE', | ||
| MORE: 'MORE', | ||
| LESS: 'LESS', | ||
| TRANSACTION: 'TRANSACTION', |
Collaborator
There was a problem hiding this comment.
Add a comment where the first 4 values are used right now, where those last 3 are used, I mean generally "what's happening here"
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5235 +/- ##
============================================
- Coverage 8.31% 8.31% -0.01%
- Complexity 969 971 +2
============================================
Files 638 638
Lines 43214 43246 +32
Branches 10503 10511 +8
============================================
+ Hits 3594 3596 +2
- Misses 39068 39097 +29
- Partials 552 553 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
awalkowiak
approved these changes
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket:
Description:
📷 Screenshots & Recordings (optional)