OBPIH-7042 Add Zone to Bin location filter in cycle count tabs#5221
OBPIH-7042 Add Zone to Bin location filter in cycle count tabs#5221awalkowiak merged 3 commits intodevelopfrom
Conversation
github-actions
bot
added
the
domain: frontend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5221 +/- ##
============================================
- Coverage 8.19% 8.12% -0.07%
+ Complexity 950 939 -11
============================================
Files 638 638
Lines 43214 43214
Branches 10503 10503
============================================
- Hits 3542 3512 -30
- Misses 39130 39166 +36
+ Partials 542 536 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| catalogs: catalogList, | ||
| tags: tagList, | ||
| internalLocations: binList, | ||
| internalLocations: groupBinLocationsByZone(binList, translate), |
There was a problem hiding this comment.
could you describe the reason for translate needing to be passed to the method?
There was a problem hiding this comment.
I had to pass translate to groupBinLocationsByZone because I was getting an "Invalid Hook Call" error in useCycleCountFilters when I tried using it without passing translate. That’s how I worked around it
There was a problem hiding this comment.
And why was it working in the useCountStepTable before, without needing to pass it with params?
There was a problem hiding this comment.
I think we didn’t have to pass translate to groupBinLocationsByZone in useCountStepTable because the function is called synchronously during render. But in useCycleCountFilters, it’s used inside an async function, so without passing translate this won't work
3 participants
✨ Description of Change
Link to GitHub issue or Jira ticket:
Description:
📷 Screenshots & Recordings (optional)