OBPIH-7147 Separate Pack levels in Delivery Note#5219
Conversation
github-actions
bot
added
the
domain: frontend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5219 +/- ##
============================================
+ Coverage 8.19% 8.27% +0.08%
- Complexity 950 961 +11
============================================
Files 638 638
Lines 43214 43214
Branches 10503 10503
============================================
+ Hits 3542 3577 +35
+ Misses 39130 39087 -43
- Partials 542 550 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| <g:set var="shipmentItems" value="${requisitionItem?.requisition?.shipment?.shipmentItems?.findAll { it.requisitionItem == requisitionItem }}"/> | ||
| <g:set var="picklistItemsGroup" value="${inventoryItemMap?.values()?.toList()}"/> | ||
| <g:set var="numInventoryItem" value="${inventoryItemMap?.size() ?: 1}"/> | ||
| <g:set var="shipmentItemCount" value="${shipmentItems ? shipmentItems.size() : (inventoryItemMap?.size() ?: 1)}"/> |
There was a problem hiding this comment.
Why fallback to inventoryItemMap?.size() ?: 1? Should it not be just shipmentItems.size() ?: 1 now?
| <g:if test="${j==0}"> | ||
| <g:else> | ||
| <div class="${requisitionItem?.status}"> | ||
| ${requisitionItem?.totalQuantityPicked() ?: 0} ${requisitionItem?.product?.unitOfMeasure ?: "EA"} |
There was a problem hiding this comment.
Is this line correct? Should not it be:
${requisitionItem?.quantity ?: 0} ${requisitionItem?.product?.unitOfMeasure ?: "EA"}
?
| <td class="center middle"> | ||
| <g:if test="${picklistItemsGroup}"> | ||
| <g:if test="${shipmentItem}"> | ||
| ${shipmentItem?.quantity ?: 0} ${requisitionItem?.product?.unitOfMeasure ?: "EA"} |
There was a problem hiding this comment.
Should this column header be Delivered by container if there are shipment items? And Delivered by lot if the data is pulled from grouped picklist items?
github-actions
bot
added
the
domain: l10n
| <g:set var="numInventoryItem" value="${inventoryItemMap?.size() ?: 1}"/> | ||
| <g:set var="shipmentItemCount" value="${shipmentItems.size() ?: 1}"/> | ||
| </g:if> | ||
| <g:else> |
There was a problem hiding this comment.
You could get rid of else block here and gave one shipmentItemCount var.
| <th>${g.message(code: 'deliveryNote.deliveredByLot.label', default: "Delivered by Lot")}</th> | ||
| <th> | ||
| <g:if test="${requisitionItems.find { it.requisition?.shipment?.shipmentItems?.any { it.container }}}"> | ||
| ${g.message(code: 'deliveryNote.deliveredByContainer.label', default: "Delivered by Container")} |
There was a problem hiding this comment.
This was a question, not a change request. Ensure this is ok.
|
@awalkowiak I received this information what to do:
|
|
I still have to fix my latest changes with split received and comment, so for now I'm setting this PR as draft |
3 participants
✨ Description of Change
Link to GitHub issue or Jira ticket:
Description:
📷 Screenshots & Recordings (optional)