OBPIH-6780 Add Page numbers on Picklist and Delivery Note#5199
OBPIH-6780 Add Page numbers on Picklist and Delivery Note#5199awalkowiak merged 3 commits intodevelopfrom
Conversation
github-actions
bot
added
the
domain: frontend
| size: letter; | ||
| background: white; | ||
| @top-center { content: element(header) } | ||
| @bottom-center { content: element(footer) } |
There was a problem hiding this comment.
Actually, this element doesn’t even exist in the file, so I could remove the style for div.footer. But since a lot of the other unused styles haven’t been removed either, I’m not going to remove this one for now. Or maybe should I?
There was a problem hiding this comment.
Remind me, why you could not re-add the:
<div class="footer">
<div id="page-footer" class="small">
<div>
Page <span class="page" /> of <span class="pagecount" />
</div>
</div>
</div>
We have all the styling there, so perhaps this could work as well?
There was a problem hiding this comment.
Ok then i think you can get rid of the unused styling
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5199 +/- ##
=========================================
Coverage 8.12% 8.12%
Complexity 939 939
=========================================
Files 638 638
Lines 43211 43211
Branches 10503 10503
=========================================
Hits 3512 3512
Misses 39163 39163
Partials 536 536 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
✨ Description of Change
Link to GitHub issue or Jira ticket:
Description:
📷 Screenshots & Recordings (optional)