OBPIH-7117 duplicate items error should also show on lot number field#5153
Merged
OBPIH-7117 duplicate items error should also show on lot number field#5153
Conversation
ewaterman
requested review from
SebastianLib,
alannadolny,
awalkowiak and
kchelstowski
github-actions
bot
added
type: bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5153 +/- ##
=========================================
Coverage 8.11% 8.11%
Complexity 937 937
=========================================
Files 637 637
Lines 43137 43137
Branches 10488 10488
=========================================
Hits 3500 3500
Misses 39100 39100
Partials 537 537 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alannadolny
approved these changes
Mar 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket: https://pihemr.atlassian.net/browse/OBPIH-7117
Description: When one or more custom rows have the same [bin + lot] as another row, display an error on both the bin and lot fields for that row. Previously we were just displaying the error on the bin field, which isn't present for facilities with bin disabled, and so the error wasn't visible.
📷 Screenshots & Recordings (optional)
For facility with bin location enabled:
For facility with bin location disabled:
