OBPIH- 6901 bugfix. Make QuantityVariance properly handle 0 quantity#5128
Merged
awalkowiak merged 1 commit intodevelopfrom Mar 14, 2025
Merged
OBPIH- 6901 bugfix. Make QuantityVariance properly handle 0 quantity#5128awalkowiak merged 1 commit intodevelopfrom
awalkowiak merged 1 commit intodevelopfrom
Conversation
github-actions
bot
added
type: bug
ewaterman
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5128 +/- ##
============================================
- Coverage 8.15% 8.12% -0.04%
+ Complexity 945 942 -3
============================================
Files 636 636
Lines 43123 43124 +1
Branches 10486 10486
============================================
- Hits 3518 3505 -13
- Misses 39058 39076 +18
+ Partials 547 543 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ewaterman
requested review from
alannadolny,
awalkowiak and
kchelstowski
and removed request for
awalkowiak
kchelstowski
approved these changes
Mar 14, 2025
alannadolny
approved these changes
Mar 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket: https://pihemr.atlassian.net/browse/OBPIH-6901
Description: Fix
CycleCountItem.getQuantityVariance()so that it doesn't return null when eitherquantityCountedorquantityOnHand== 0📷 Screenshots & Recordings (optional)
https://jam.dev/c/ed162de1-0420-4c82-839d-fcc395b7f185
8581a846-4b1e-49e0-90d6-37d28346d590.webm