Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 8.13%. Comparing base (0b46d2b) to head (b644220).
Report is 172 commits behind head on develop.

@@             Coverage Diff              @@
##             develop   #5124      +/-   ##
============================================
+ Coverage       8.09%   8.13%   +0.03%     
- Complexity       934     942       +8     
============================================
  Files            636     636              
  Lines          43102   43102              
  Branches       10480   10480              
============================================
+ Hits            3488    3505      +17     
+ Misses         39073   39054      -19     
- Partials         541     543       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

I was trying to check for any potential knock on effects of removing the this.value = ui.item.label; assignment and I couldn't find anything but I'm still not totally sure the different purposes between _globalSearch.gsp and _globalSearchStatic.gsp.

The files are near identical with just a few additional changes in the non-static version. It looks like the static version only has a single commit: 4eaba52

GlobalSearchTagLib.groovy has:

if (attrs.buttonId) {
    out << g.render(template: '/taglib/globalSearch', model: [attrs: attrs])
} else {
    out << g.render(template: '/taglib/globalSearchStatic', model: [attrs: attrs])
}

and _menuicons.gsp has:

<g:globalSearch buttonId="global-search-button" jsonUrl="${request.contextPath}/json/globalSearch"/>

and

<g:globalSearch jsonUrl="${request.contextPath}/json/globalSearch"/>

but I got lost debugging beyond that so I'm not sure what triggers each of these flows. I could dig further but I'm ending my day and so I figured I'd throw it out to the rest of you in case you have any ideas.