OBPIH-6909 Unify roles on menu items in navbar#5049
Merged
awalkowiak merged 2 commits intodevelopfrom Feb 17, 2025
Merged
Conversation
awalkowiak
requested review from
SebastianLib,
alannadolny,
ewaterman and
kchelstowski
github-actions
bot
added
the
domain: frontend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5049 +/- ##
============================================
+ Coverage 7.75% 7.84% +0.08%
- Complexity 860 876 +16
============================================
Files 613 625 +12
Lines 42623 42813 +190
Branches 10350 10376 +26
============================================
+ Hits 3306 3358 +52
- Misses 38823 38952 +129
- Partials 494 503 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ewaterman
reviewed
Feb 14, 2025
| </g:if> | ||
| <g:each in="${subsection?.menuItems}" var="item"> | ||
| <a href="${item?.href}" class="dropdown-item"> | ||
| <a href="${item?.href}" class="dropdown-item" role="menuitem"> |
Member
There was a problem hiding this comment.
I thought these roles were only used for accessibility/screen readers. Are the tests looking specifically for the role?
Collaborator
Author
There was a problem hiding this comment.
Yes, E2E tests rely on the role selectors as well. Half of our menu already had this role, I am adding it to the missing parts so the tests can be unified.
alannadolny
approved these changes
Feb 17, 2025
awalkowiak
added a commit
that referenced
this pull request
Feb 17, 2025
SebastianLib
pushed a commit
that referenced
this pull request
Feb 19, 2025
awalkowiak
added a commit
that referenced
this pull request
Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket:
https://pihemr.atlassian.net/browse/OBPIH-6909
Description:
Unifying (adding missing) roles on menu items in navbar. Needed by E2E tests.