OBPIH-6974 Create the recount form connecting with the data by alannadolny · Pull Request #5047 · openboxes/openboxes

alannadolny · 2025-02-13T16:01:42Z

✨ Description of Change

A concise summary of what is being changed. Please provide enough context for reviewers to be able to understand the change and why it is necessary. If the issue/ticket already provides enough information, you can put "See ticket" as the description.

Link to GitHub issue or Jira ticket:

Description: Things that should be added later:

Replace randomized Quantity Counted (I used math.random)
Replace name (counted by and date) with values from API (ticket is already created)
Remove the randomized Quantity Counted in the Count Difference column after getting it in the response
Replace the mocked comment from the count step

📷 Screenshots & Recordings (optional)

If this PR contains a UI change, consider adding one or more screenshots here or link to a screen recording to help reviewers visualize the change. Otherwise, you can remove this section.

codecov · 2025-02-17T10:26:40Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 7.84%. Comparing base (4b8ba88) to head (94acae4).
Report is 202 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff              @@
##             develop   #5047      +/-   ##
============================================
- Coverage       7.88%   7.84%   -0.04%     
+ Complexity       884     876       -8     
============================================
  Files            625     625              
  Lines          42813   42813              
  Branches       10376   10376              
============================================
- Hits            3375    3358      -17     
- Misses         38933   38952      +19     
+ Partials         505     503       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

awalkowiak

I have two questions that are not change requests (at least yet)

awalkowiak · 2025-02-17T12:26:34Z

src/js/components/Router.jsx

            <MainLayoutRoute path="**/stockMovement/createOutbound/:stockMovementId?" component={AsyncStockMovement} />
            <MainLayoutRoute path="**/stockMovement/importOutboundStockMovement" component={AsyncOutboundImport} />
            <MainLayoutRoute path="**/inventory/cycleCount/count" component={AsyncCycleCountCountStep} />
+            <MainLayoutRoute path="**/inventory/cycleCount/resolve" component={AsyncCycleCountResolveStep} />


[Discussion] - If I understand this correctly there are no steps involved there, perhaps it would be better to rename "steps" into "forms"?

I treated it as the next step of the selection (after to count tab)

awalkowiak · 2025-02-17T12:30:28Z

src/js/components/cycleCount/toResolveTab/ResolveStepTable.jsx

+            <p className="count-step-label count-step-label-date-counted mr-2 mt-2">
+              {translate('react.cycleCount.dateCounted.label', 'Date Counted')}
+              <span className="count-step-value ml-1">
+                {formatLocalizedDate(dateCounted, DateFormat.DD_MM_YYYY)}


Why we are using this date format here? Weren't we recently unifying or changing the date format to a specific one?

it's the date format from mock

@alannadolny You mean this one:

?

How do you know which part is the day and which part is the month?

awalkowiak

One more question popped up in my head while rereviewing this one

awalkowiak · 2025-02-18T11:43:46Z

src/js/components/cycleCount/toResolveTab/ResolveStepTable.jsx

+  const {
+    columns,
+    defaultColumn,
+    recipients,


Why it is called recipients?

because i copied it 😄

alannadolny requested review from SebastianLib, awalkowiak and kchelstowski February 13, 2025 16:01

alannadolny self-assigned this Feb 13, 2025

alannadolny added 14 commits February 17, 2025 11:04

OBPIH-6974 Add new route

3c5bcf6

OBPIH-6974 Add discrepancy reason codes (temp)

205c91f

OBPIH-6974 Add new redux action

548c298

OBPIH-6974 Add new date format for displaying in header

9f29554

OBPIH-6974 Add header namings in enum

437a92b

OBPIH-6974 Add new translations

1a8f21f

OBPIH-6974 Remove empty new line

4de486c

OBPIH-6974 Move to resolve tab

79bdd3d

OBPIH-6974 Move to the recounting page

303cff7

OBPIH-6974 Add resolve step & header

cd0d054

OBPIH-6974 Add resolve step table

d46c9a9

OBPIH-6974 Add hooks for handling logic and fix styling

8748add

OBPIH-6974 Use already existing reason codes instead of discrepancies

7214fce

OBPIH-6974 Add useMemo and useCallback hooks

7ac39e1

alannadolny force-pushed the OBPIH-6974 branch from 46ef12e to e14fcf4 Compare February 17, 2025 10:15

github-actions bot added domain: frontend Changes or discussions relating to the frontend UI domain: l10n Changes or discussions relating to localization & Internationalization labels Feb 17, 2025

OBPIH-6974 Fix eslint errors

d74a75b

alannadolny force-pushed the OBPIH-6974 branch from e14fcf4 to d74a75b Compare February 17, 2025 10:19

OBPIH-6974 Adjust columns sizes

ee5d50c

awalkowiak reviewed Feb 17, 2025

View reviewed changes

alannadolny and others added 2 commits February 18, 2025 11:18

OBPIH-6975 Create component for columns with up vs down styling (#5053)

89cd239

OBPIH-6974 Change date format

875ba08

awalkowiak reviewed Feb 18, 2025

View reviewed changes

OBPIH-6974 Rename recipients to users

94acae4

awalkowiak approved these changes Feb 18, 2025

View reviewed changes

awalkowiak merged commit 74f6131 into develop Feb 19, 2025
9 checks passed

awalkowiak deleted the OBPIH-6974 branch February 19, 2025 09:47

SebastianLib pushed a commit that referenced this pull request Feb 19, 2025

OBPIH-6974 Create the recount form connecting with the data (#5047)

6d54834

Uh oh!

Conversation

alannadolny commented Feb 13, 2025

✨ Description of Change

📷 Screenshots & Recordings (optional)

Uh oh!

codecov bot commented Feb 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

awalkowiak left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

awalkowiak left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Feb 17, 2025 •

edited

Loading