Default logo returns a 404 error (fixes #5041)#5043
Conversation
jmiranda
requested review from
alannadolny,
awalkowiak,
ewaterman and
kchelstowski
github-actions
bot
added
the
flag: config change
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5043 +/- ##
=========================================
Coverage 7.84% 7.84%
Complexity 876 876
=========================================
Files 624 624
Lines 42815 42815
Branches 10375 10375
=========================================
Hits 3357 3357
Misses 38955 38955
Partials 503 503 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ewaterman
left a comment
ewaterman
left a comment
There was a problem hiding this comment.
Since this is 404ing already, I'm fine with merging it in and seeing what happens
| # Allow users to customize logo image url as well as label | ||
| logo: | ||
| url: "/assets/openboxes_logo_40x40.jpg" | ||
| url: "${server.contextPath}/assets/openboxes_logo_40x40.jpg" |
There was a problem hiding this comment.
And this does not affect the displayLogo tag? I mean, that this won't produce there /openboxes/openboxes/assets/openboxes_logo_40x40.jpg?
There was a problem hiding this comment.
@awalkowiak Good point. I'll test it out, but I'm sure it does do that.
Can you and @alannadolny review ticket #5041 and see if you can think of a better approach?
There was a problem hiding this comment.
Perhaps, we just need to make the change on the API side like Approach 3 suggests.
There was a problem hiding this comment.
It looks like it works fine within displayLogo too. Therefore I'm going to merge as-is
3 participants
Fixed a long-standing bug with 0.9.x releases where the default configuration leads to a 404 error when rendering the default logo. See #5041 for more information.
This was tested locally using grails run-app, but I have not tested this as part of an actual deployment. If we encounter any issues with this approach, I'm going to hard-code the context path.