OBPIH-6895 Load the count confirmation page#5035
Conversation
OBPIH-6895 Load the count confirmation page OBPIH-6895 Load the count confirmation page
OBPIH-6895 Load the count confirmation page OBPIH-6895 Load the count confirmation page
github-actions
bot
added
domain: frontend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5035 +/- ##
============================================
+ Coverage 7.76% 7.80% +0.03%
- Complexity 860 868 +8
============================================
Files 620 620
Lines 42760 42760
Branches 10373 10373
============================================
+ Hits 3321 3338 +17
+ Misses 38945 38926 -19
- Partials 494 496 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| {translate('react.cycleCount.dateCounted.label', 'Date counted')} | ||
| </span> | ||
| {' '} | ||
| <span>{moment(dateCounted).format('DD/MM/YYYY')}</span> |
There was a problem hiding this comment.
I thought we had a constant for the date formats. Maybe it would be good to have one. Thoughts?
There was a problem hiding this comment.
use formatDate from translation-utils
| }), {}); | ||
| setDateCounted(countedDates); | ||
| })(); | ||
| }, [cycleCountIds, currentLocation]); |
|
|
||
| const getCountedDate = (cycleCountId) => dateCounted[cycleCountId]; | ||
|
|
||
| const columns = [ |
There was a problem hiding this comment.
isn't there useMemo missing? I know there were problems with translations, but we need to figure out the bug, instead of getting rid of the memoization.
| } | ||
| } | ||
|
|
||
| "/inventory/cycleCount/count/check" { |
There was a problem hiding this comment.
Do we have to have a separate URL for it? Imho a simple two step wizard under /inventory/cycleCount/count would make more sense.
There was a problem hiding this comment.
@SebastianLib on second thought we don't even need a separate page/step for it. It is just a state with disabled editing and two buttons changed
| react.default.button.undoEdit.label=Undo edit | ||
| react.default.button.download.label=Download | ||
| react.default.button.availableDraft.label=Available draft | ||
| react.default.button.back.label=Back |
There was a problem hiding this comment.
Doesn't it already exist?
I can see it on line 298 line
| {translate('react.cycleCount.dateCounted.label', 'Date counted')} | ||
| </span> | ||
| {' '} | ||
| <span>{moment(dateCounted).format('DD/MM/YYYY')}</span> |
There was a problem hiding this comment.
use formatDate from translation-utils
4 participants
OBPIH-6895 Load the count confirmation page
OBPIH-6895 Load the count confirmation page
✨ Description of Change
Link to GitHub issue or Jira ticket:
Description:
📷 Screenshots & Recordings (optional)