OBPIH-6894 Load the count step page#5033
Conversation
github-actions
bot
added
domain: frontend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5033 +/- ##
=========================================
Coverage 7.76% 7.76%
Complexity 860 860
=========================================
Files 620 620
Lines 42760 42760
Branches 10373 10373
=========================================
Hits 3321 3321
Misses 38945 38945
Partials 494 494 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alannadolny
requested review from
SebastianLib,
awalkowiak,
ewaterman and
kchelstowski
alannadolny
force-pushed
the
OBPIH-6894-3
branch
from
96c51fa to
bfef62c
Compare
src/js/actions/index.js
Outdated
| SHOW_INFO_BAR, | ||
| SHOW_INFO_BAR_MODAL, | ||
| SHOW_SPINNER, | ||
| SHOW_SPINNER, START_COUNT, |
There was a problem hiding this comment.
let's move it to another line
| }), {}); | ||
| setDateCounted(countedDates); | ||
| })(); | ||
| }, [cycleCountIds]); |
There was a problem hiding this comment.
if it's an array, won't it re-render every time (new reference)?
There was a problem hiding this comment.
it won't re-render, because the reference doesn't change in that case.
src/js/reducers/cycleCountReducer.js
Outdated
| case START_COUNT: | ||
| return { | ||
| ...state, | ||
| toCount: action.payload, |
There was a problem hiding this comment.
let's map it in the same way like it is sent to the backend, so let's name it as requests
src/js/consts/timeFormat.js
Outdated
| MMM_DD_YYYY: 'MMM DD, YYYY', | ||
| MMM_DD_YYYY_HH_MM_SS: 'MMM DD, YYYY HH:mm:ss', | ||
| MM_DD_YYYY_HH_MM_Z: 'MM/DD/YYYY HH:mm Z', | ||
| DD_MM_YYYY: 'DD/MM/YYYY', |
| const addEmptyRow = (productCode, id) => { | ||
| // ID is needed for updating appropriate row | ||
| const emptyRow = { | ||
| id: _.uniqueId('newRow'), |
There was a problem hiding this comment.
Is this sanitized before sending it to the backend? Or it is not sent?
There was a problem hiding this comment.
it's not sent at this moment
3 participants
✨ Description of Change
Link to GitHub issue or Jira ticket:
Description:
📷 Screenshots & Recordings (optional)