Skip to content

OBPIH-6978 Fix creating a cycle count item with the default bin assigned#5032

Merged
awalkowiak merged 1 commit intodevelopfrom
OBPIH-6978-fix
Feb 7, 2025
Merged

OBPIH-6978 Fix creating a cycle count item with the default bin assigned#5032
awalkowiak merged 1 commit intodevelopfrom
OBPIH-6978-fix

Conversation

@kchelstowski
Copy link
Collaborator

@kchelstowski kchelstowski commented Feb 6, 2025

✨ Description of Change

A concise summary of what is being changed. Please provide enough context for reviewers to be able to understand the change and why it is necessary. If the issue/ticket already provides enough information, you can put "See ticket" as the description.

Link to GitHub issue or Jira ticket:

Description:

📷 Screenshots & Recordings (optional)

If this PR contains a UI change, consider adding one or more screenshots here or link to a screen recording to help reviewers visualize the change. Otherwise, you can remove this section.

@kchelstowski kchelstowski self-assigned this Feb 6, 2025
@github-actions github-actions bot added domain: backend Changes or discussions relating to the backend server flag: schema change Hilights a pull request that contains a change to the database schema labels Feb 6, 2025
@codecov
Copy link

codecov bot commented Feb 6, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 7.76%. Comparing base (8cb3eed) to head (919f581).
Report is 199 commits behind head on develop.

Files with missing lines Patch % Lines
.../org/pih/warehouse/inventory/CycleCountItem.groovy 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             develop   #5032   +/-   ##
=========================================
  Coverage       7.76%   7.76%           
  Complexity       860     860           
=========================================
  Files            620     620           
  Lines          42759   42760    +1     
  Branches       10373   10373           
=========================================
+ Hits            3320    3321    +1     
  Misses         38945   38945           
  Partials         494     494

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@awalkowiak awalkowiak merged commit d0d9670 into develop Feb 7, 2025
9 checks passed
@awalkowiak awalkowiak deleted the OBPIH-6978-fix branch February 7, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@awalkowiak awalkowiak awalkowiak approved these changes

@ewaterman ewaterman Awaiting requested review from ewaterman

@drodzewicz drodzewicz Awaiting requested review from drodzewicz

@alannadolny alannadolny Awaiting requested review from alannadolny

@SebastianLib SebastianLib Awaiting requested review from SebastianLib

Assignees

@kchelstowski kchelstowski

Labels

domain: backend Changes or discussions relating to the backend server flag: schema change Hilights a pull request that contains a change to the database schema

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kchelstowski @awalkowiak