OBPIH-6966 Create an endpoint to get cycle counts#5027
Merged
awalkowiak merged 1 commit intodevelopfrom Feb 5, 2025
Merged
Conversation
kchelstowski
requested review from
SebastianLib,
alannadolny,
awalkowiak and
ewaterman
github-actions
bot
added
the
domain: backend
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5027 +/- ##
=========================================
Coverage 7.79% 7.80%
Complexity 868 868
=========================================
Files 620 620
Lines 42744 42757 +13
Branches 10370 10373 +3
=========================================
+ Hits 3334 3337 +3
- Misses 38914 38924 +10
Partials 496 496 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ewaterman
reviewed
Feb 4, 2025
| } | ||
|
|
||
| List<CycleCountDto> getCycleCounts(List<String> ids) { | ||
| List<CycleCount> cycleCounts = CycleCount.createCriteria().list { |
Member
There was a problem hiding this comment.
I think you can do CycleCount.findByIdIn(ids)
Collaborator
Author
There was a problem hiding this comment.
I wanted to allow fetching all if you don't provide the ids, so this wouldn't work with version you proposed. I think those versions are anyway almost equal, it's just "syntatic sugar".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket:
Description:
📷 Screenshots & Recordings (optional)