OBPIH-6959 use ABC Class from inventory level in cycle count products list#5020
Merged
awalkowiak merged 1 commit intodevelopfrom Jan 29, 2025
Conversation
github-actions
bot
added
type: bug
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5020 +/- ##
=========================================
Coverage 7.75% 7.75%
Complexity 860 860
=========================================
Files 613 613
Lines 42623 42622 -1
Branches 10350 10350
=========================================
Hits 3306 3306
+ Misses 38823 38822 -1
Partials 494 494 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kchelstowski
approved these changes
Jan 29, 2025
alannadolny
approved these changes
Jan 29, 2025
awalkowiak
deleted the
bug/OBPIH-6959-cycle-count-session-use-inventory-level-abcclass
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket: https://pihemr.atlassian.net/browse/OBPIH-6959
Description: When generating abcClass in cycle_count_session, first check if there's an inventory level defined for the product, and use abcClass from there. Otherwise fallback to the abcClass as defined in the product