OBPIH-6936 remove duplicates from product classification list endpoint#5019
Merged
awalkowiak merged 2 commits intodevelopfrom Jan 30, 2025
Merged
Conversation
github-actions
bot
added
type: bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5019 +/- ##
============================================
- Coverage 7.75% 7.75% -0.01%
Complexity 860 860
============================================
Files 613 613
Lines 42623 42621 -2
Branches 10350 10350
============================================
- Hits 3306 3305 -1
+ Misses 38823 38822 -1
Partials 494 494 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alannadolny
reviewed
Jan 29, 2025
Comment on lines
62
to
65
| return productClassifications.stream() | ||
| // Once ABC class becomes its own domain, this sort by name can be moved to the query. | ||
| .sorted() | ||
| .collect{ new ProductClassificationDto(name: it) } |
Collaborator
There was a problem hiding this comment.
do you have to use stream here? 🤔
Can't it be just:
Suggested change
| return productClassifications.stream() | |
| // Once ABC class becomes its own domain, this sort by name can be moved to the query. | |
| .sorted() | |
| .collect{ new ProductClassificationDto(name: it) } | |
| return productClassifications | |
| // Once ABC class becomes its own domain, this sort by name can be moved to the query. | |
| .sort() | |
| .collect{ new ProductClassificationDto(name: it) } |
Member
Author
There was a problem hiding this comment.
you're right. I'm still too Java-brained 😅
awalkowiak
approved these changes
Jan 30, 2025
awalkowiak
deleted the
bug/OBPIH-6936-remove-dupes-from-product-classifications
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket: https://pihemr.atlassian.net/browse/OBPIH-6936
Description: Remove duplicates from the product classification list endpoint by fetching the ABC classes as a Set
📷 Screenshots & Recordings (optional)