Skip to content

OBPIH-6936 filter out empty ABC classes from cycle count filter dropdown#5017

Merged
ewaterman merged 1 commit intodevelopfrom
bug/OBPIH-6936-cycle-count-filter-empty-option
Jan 27, 2025
Merged

OBPIH-6936 filter out empty ABC classes from cycle count filter dropdown#5017
ewaterman merged 1 commit intodevelopfrom
bug/OBPIH-6936-cycle-count-filter-empty-option

Conversation

@ewaterman
Copy link
Member

✨ Description of Change

Link to GitHub issue or Jira ticket: https://pihemr.atlassian.net/browse/OBPIH-6936

Description: Filter out null and empty string ABC classifications when fetching them for the cycle count filter dropdown so that we don't get a confusing empty option.


📷 Screenshots & Recordings (optional)

image

@ewaterman ewaterman self-assigned this Jan 24, 2025
@github-actions github-actions bot added type: bug Addresses unintended behaviours of the app domain: backend Changes or discussions relating to the backend server labels Jan 24, 2025
@codecov
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 7.75%. Comparing base (d8d1353) to head (9464f77).
Report is 209 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##             develop   #5017   +/-   ##
=========================================
  Coverage       7.74%   7.75%           
- Complexity       859     860    +1     
=========================================
  Files            613     613           
  Lines          42621   42623    +2     
  Branches       10350   10350           
=========================================
+ Hits            3303    3306    +3     
+ Misses         38825   38823    -2     
- Partials         493     494    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ewaterman ewaterman merged commit 3cb888e into develop Jan 27, 2025
9 checks passed
@ewaterman ewaterman deleted the bug/OBPIH-6936-cycle-count-filter-empty-option branch January 27, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: backend Changes or discussions relating to the backend server type: bug Addresses unintended behaviours of the app

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants