Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5017 +/- ##
=========================================
Coverage 7.74% 7.75%
- Complexity 859 860 +1
=========================================
Files 613 613
Lines 42621 42623 +2
Branches 10350 10350
=========================================
+ Hits 3303 3306 +3
+ Misses 38825 38823 -2
- Partials 493 494 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alannadolny
approved these changes
Jan 27, 2025
awalkowiak
approved these changes
Jan 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket: https://pihemr.atlassian.net/browse/OBPIH-6936
Description: Filter out null and empty string ABC classifications when fetching them for the cycle count filter dropdown so that we don't get a confusing empty option.
📷 Screenshots & Recordings (optional)