OBPIH-6850 Create table component to count tab#5012
Conversation
github-actions
bot
added
the
domain: frontend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5012 +/- ##
============================================
+ Coverage 7.74% 7.78% +0.04%
- Complexity 855 867 +12
============================================
Files 613 613
Lines 42621 42621
Branches 10350 10350
============================================
+ Hits 3302 3320 +18
+ Misses 38825 38806 -19
- Partials 494 495 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| </TableCell> | ||
| ), | ||
| cell: ({ getValue }) => { | ||
| const binLocationList = mapStringToList(getValue(), ','); |
There was a problem hiding this comment.
How long can this list potentially be?
There was a problem hiding this comment.
The longest list that I have locally is 13 bin locations
There was a problem hiding this comment.
Should it be capped at 4 bins like on the other page?
There was a problem hiding this comment.
it is, but in OBPIH-6942
There was a problem hiding this comment.
Sounds good. On a side note, this mapStringToList should be named differently, because I'd say instead of mapStringToList it should be a simple split, unless it does something more beyond that that I am not aware looking at this part of the code.
3 participants
No description provided.