OBPIH-6850 Create table component to count tab#5006
Conversation
github-actions
bot
added
domain: frontend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5006 +/- ##
============================================
+ Coverage 7.72% 7.78% +0.05%
- Complexity 854 863 +9
============================================
Files 610 613 +3
Lines 42589 42621 +32
Branches 10346 10350 +4
============================================
+ Hits 3292 3319 +27
+ Misses 38810 38806 -4
- Partials 487 496 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| {tab === TO_COUNT_TAB && <CycleCountToCount />} | ||
| {tab === TO_COUNT_TAB && ( | ||
| <CycleCountToCount | ||
| filterParams={filterParams} |
There was a problem hiding this comment.
are filters cleared when switching between tabs?
There was a problem hiding this comment.
no, and I thought it was the desired behavior, but I will ask for clarification
There was a problem hiding this comment.
Manon confirmed that it should be cleared
| const translate = useTranslate(); | ||
| const spinner = useSpinner(); | ||
| const [pageSize, setPageSize] = useState(5); | ||
| const [offset, setOffset] = useState(0); |
There was a problem hiding this comment.
couldn't those two states be placed in a separate common hook? I can see it being repeated from the useAllProductsTab. I can see it even being used in the useTableDataV2 with those values with ability to override those (while passing those to the useTableDataV2)
| cell: () => ( | ||
| <TableCell className="rt-td"> | ||
| <StatusIndicator | ||
| variant="danger" |
There was a problem hiding this comment.
let's leave a TODO to remember to change it when the statuses have the variant implemented.
3 participants
✨ Description of Change
Link to GitHub issue or Jira ticket:
Description:
📷 Screenshots & Recordings (optional)