OBPIH-6925 removed numbers from Tags and Product Catalogue filter#5003
Merged
kchelstowski merged 6 commits intodevelopfrom Jan 20, 2025
Merged
OBPIH-6925 removed numbers from Tags and Product Catalogue filter#5003kchelstowski merged 6 commits intodevelopfrom
kchelstowski merged 6 commits intodevelopfrom
Conversation
github-actions
bot
added
the
domain: backend
alannadolny
reviewed
Jan 17, 2025
Collaborator
alannadolny
left a comment
alannadolny
left a comment
There was a problem hiding this comment.
Was it requested to be done for each dropdown?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5003 +/- ##
============================================
- Coverage 7.69% 7.68% -0.01%
Complexity 846 846
============================================
Files 610 610
Lines 42581 42589 +8
Branches 10343 10346 +3
============================================
Hits 3275 3275
- Misses 38821 38829 +8
Partials 485 485 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
grails-app/controllers/org/pih/warehouse/api/SelectOptionsApiController.groovy
Outdated
Show resolved
Hide resolved
…y for cycle count
github-actions
bot
added
the
domain: frontend
Collaborator
kchelstowski
left a comment
kchelstowski
left a comment
There was a problem hiding this comment.
lgtm, just fix formatting
| } | ||
|
|
||
|
|
||
|
|
Collaborator
There was a problem hiding this comment.
remove unnecessary indentations
| def catalogOptions() { | ||
| List<ProductCatalog> catalogs = genericApiService.getList(ProductCatalog.class.simpleName, [sort: "name"]).collect { | ||
| [id: it.id, label: "${it.name} (${it?.productCatalogItems?.size()})"] | ||
| boolean hideNumbers = params.boolean('hideNumbers', false) |
Collaborator
There was a problem hiding this comment.
nitpicky: we tend to use " " on the backend and it feels like you changed them from " " to ' '
|
|
||
|
|
||
| </div> | ||
| </span> |
Collaborator
There was a problem hiding this comment.
why is this file changed?
kchelstowski
approved these changes
Jan 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket:
Description:
📷 Screenshots & Recordings (optional)