OBPIH-6848 Count selected button all products tab#5001
Merged
kchelstowski merged 2 commits intodevelopfrom Jan 20, 2025
Merged
Conversation
alannadolny
added
the
warn: do not merge
github-actions
bot
added
domain: frontend
Collaborator
kchelstowski
left a comment
kchelstowski
left a comment
There was a problem hiding this comment.
lgtm, but seems like you have an eslint error in useAllProductsTab
alannadolny
force-pushed
the
OBPIH-6846
branch
from
4d466cb to
eb5ab59
Compare
alannadolny
force-pushed
the
OBPIH-6848
branch
from
e2efc34 to
bdca201
Compare
alannadolny
removed
the
warn: do not merge
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5001 +/- ##
============================================
- Coverage 7.76% 7.68% -0.08%
+ Complexity 857 846 -11
============================================
Files 610 610
Lines 42586 42589 +3
Branches 10344 10346 +2
============================================
- Hits 3305 3275 -30
- Misses 38790 38829 +39
+ Partials 491 485 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alannadolny
force-pushed
the
OBPIH-6848
branch
from
bdca201 to
3a678b7
Compare
kchelstowski
approved these changes
Jan 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should be merged after OBPIH-6889 and OBPIH-6846