OBPIH-6922 Shorten the Name of Bin Location#5000
Merged
kchelstowski merged 5 commits intodevelopfrom Jan 20, 2025
Merged
Conversation
github-actions
bot
added
the
domain: frontend
alannadolny
reviewed
Jan 16, 2025
Comment on lines
138
to
153
| cell: ({ getValue }) => { | ||
| const binLocationList = mapStringToList(getValue(), ','); | ||
|
|
||
| return ( | ||
| <TableCell | ||
| className="rt-td" | ||
| tooltip | ||
| tooltipLabel={`${getValue()} (${binLocationList.length})`} | ||
| > | ||
| {binLocationList.map((binLocationName) => ( | ||
| <div> | ||
| {binLocationName.length > 16 ? `${binLocationName.substring(0, 16)}...` : binLocationName} | ||
| </div> | ||
| ))} | ||
| </TableCell> | ||
| ); |
Collaborator
There was a problem hiding this comment.
I think we should do this by CSS, not just limiting the length, because when you make the screen even smaller (I know we are supporting certain screen sizes, but a lot of users have smaller screens than those supported) the bin location won't be visible. You can achieve that by packing every bin location to the div and then just hiding the overflow.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5000 +/- ##
============================================
- Coverage 7.69% 7.69% -0.01%
Complexity 846 846
============================================
Files 610 610
Lines 42581 42586 +5
Branches 10343 10344 +1
============================================
Hits 3275 3275
- Misses 38821 38826 +5
Partials 485 485 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| tooltipLabel={`${getValue()} (${binLocationList.length})`} | ||
| > | ||
| {binLocationList.map((binLocationName) => ( | ||
| <div className="truncate-text"> |
kchelstowski
approved these changes
Jan 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket:
Description:
I shortened the bin location name and put the number of bin locations involved in the tooltip
📷 Screenshots & Recordings (optional)